Update search index on tag delete/name change.#772
Open
luku wants to merge 4 commits intoomeka:masterfrom
Open
Update search index on tag delete/name change.#772luku wants to merge 4 commits intoomeka:masterfrom
luku wants to merge 4 commits intoomeka:masterfrom
Conversation
Contributor
Author
|
Well, I see another use case for search index update where none of suggested approaches really works; When adding new record types that should be searchable in Zend_Registry::get('bootstrap')->getResource('jobs')
->sendLongRunning('Job_SearchTextIndex', array(
'records' => array(
'Item' => true,
'Collection' => true,
)
));?? Any ideas? |
Contributor
Author
|
I noticed the search index is not updated on tag delete either, so I added possibility for it as well, but 2 concerns popped up...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is solution for issue #764
It also adds possibility to update search index (instead of always creating new from scratch). The update can be accomplished in 2 ways:
record_type,record_idcolumns)@zerocrates I know you said it is too big update for version 2.5, but I think it's really practical to be able to update the search index via core job and it doesn't feel like a dangerous update or complicated one.