feat: separate segment matcher configurable #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Miura <[email protected]>
- Add preference to enable separate segment matcher - Add panalty value for separate segment matcher - Make penalty configurable for separate segment matcher - UI: add checkbox and spinner on TMMatcher preference dialog - Add TMX path as "from_separate_segment_matcher" when match it. Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
requested review from
Kazephil,
brandelune and
kosivantsov
as code owners
|
❌ Run Gradle test failed: |
- fix indent - Update supressions.xml Signed-off-by: Hiroshi Miura <[email protected]>
|
We don't need to rush a modification. Now that we understand where the issue comes from we need to discuss it and see if it is worth modifying. We can consider that as a undocumented feature and not as a bug since that's the way Alex intended to implement it. Also, it seems to appear only in very specific cases. Here, the separate string was Maybe the feature implementation is not correct (obviously I should not have a 100% match here, or it should be displayed differently). But I don't think adding another preference is the solution. |
|
There is successor #963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information