-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HunspellSpellchecker: multiple initializations #1261
base: master
Are you sure you want to change the base?
fix: HunspellSpellchecker: multiple initializations #1261
Conversation
❌ Quality checks failed. Please look a Gradle Scan page for details: |
❌ Quality checks failed. Please look a Gradle Scan page for details: |
❌ Quality checks failed. Please look a Gradle Scan page for details: |
@brandelune This PR is to fix your report in somewhere about hunspell multiple initialization. I cannot find a log archive or issue ticket. |
Considering the problem, do you have an idea how to reproduce it ? |
Please look a test case which reproduce the issue. |
User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project. The report is posted in RFE#1769 Spell checker dictionary as a language module. This is a reproducible of the issue.
Fix the case that User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project. Signed-off-by: Hiroshi Miura <[email protected]>
23adcb4
to
c73b9d9
Compare
I have rebased on master and recreate commits.
|
Line-by-line explanation for persons who don't read the java source code.
For test purpose, mocking
Check succeed the initialization
Check the initialization is done only once.
Force fire the project load event twice.
Check initialization happened 3 times, at 1st when being initialized above code, 2nd and 3rd with the fired events Without 2nd commit which fixes the issue, the last check is failed. |
User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project. The report is posted in RFE#1769 Spell checker dictionary as a language module.
Pull request type
Please mark github LABEL of the type of change your PR introduces:
Which ticket is resolved?
No ticket raised. The issue was posted as comment for the RFE.
https://sourceforge.net/p/omegat/feature-requests/1769/#7093
What does this PR change?
Other information