Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HunspellSpellchecker: multiple initializations #1261

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Feb 2, 2025

User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project. The report is posted in RFE#1769 Spell checker dictionary as a language module.

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Bug fix -> [bug]

Which ticket is resolved?

No ticket raised. The issue was posted as comment for the RFE.
https://sourceforge.net/p/omegat/feature-requests/1769/#7093

What does this PR change?

  • Add a regression test
  • Fix a multiple initializations

Other information

User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project.
The report is posted in RFE#1769 Spell checker dictionary as a language module.
This is a reproducible of the issue.
@miurahr miurahr added the bug label Feb 2, 2025
Fix the case that User observed multiple HUNSPELL_CHECKER_INITIALIZED logs when user reloading project.

Signed-off-by: Hiroshi Miura <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/ll7gc3kdvpqau

Copy link

github-actions bot commented Feb 2, 2025

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/xx3j4dfcr37hi

Signed-off-by: Hiroshi Miura <[email protected]>
Copy link

github-actions bot commented Feb 2, 2025

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/sgjp2hih4a5ie

@miurahr miurahr changed the title HunspellSpellcheckerTest: multiple initializations fix: HunspellSpellchecker: multiple initializations Feb 27, 2025
@miurahr miurahr requested a review from brandelune February 27, 2025 07:07
@miurahr
Copy link
Member Author

miurahr commented Feb 27, 2025

@brandelune This PR is to fix your report in somewhere about hunspell multiple initialization. I cannot find a log archive or issue ticket.

@brandelune
Copy link
Contributor

Signed-off-by: Hiroshi Miura <[email protected]>
@brandelune
Copy link
Contributor

Considering the problem, do you have an idea how to reproduce it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants