refactor: FindMatches class #1222
Conversation
miurahr
changed the title
- Add FindMatchesThreadTest to reproduce BUGS#1251 - Add a test case to test FindMatches with the case of BUGS#1251. Signed-off-by: Hiroshi Miura <[email protected]>
- add internal search method to handle normal and segmented search conditions, also use for test purpose - drop threshold arguments for CalcMatchStatistics usage - FindMatchesThread.finderSearch to take threshold argument for testing. - update search() callers accordingly. Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/matches/refactor-find-matches-class
branch
from
8779852 to
2c44aed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
It should be enabled when the fix is proposed. Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/matches/refactor-find-matches-class
branch
from
62fbbc7 to
f2de1ee
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
- CalcMatchStatisticsTest checks with disabling threshold, so set it -1 Signed-off-by: Hiroshi Miura <[email protected]>
|
@t-cordonnier Please be aware of the refactoring of the |
|
A core idea of refactoring List<NearString> search(String searchText, boolean fillSimilarityData, IStopped stop,
boolean runSeparateSegmentMatch) throws StoppedException { |
I will have a look but in any case this branch is rebased on the very last master, so if there were conflicts I should have seen them. |
split #963
Pull request type
refactoring
Which ticket is resolved?
What does this PR change?
Other information