Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce Core dependency for aligner #1190

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Nov 17, 2024

The Aligner depends on the Core configuration of segmentation and the filters.
It is not good to access Core API throughout the code, but it can be taken in ctor once.

Pull request type

  • Other (describe below)
    refactor

What does this PR change?

  • Add a constructor to take the segmenter as an argument for testing.
  • Logger is instantiated with Bundle.
  • Rewrite action listeners with lambdas.
  • Aligner class holds its own the segmenter and the filter master objects.

Other information

  • Acceptance test

@miurahr
Copy link
Member Author

miurahr commented Nov 19, 2024

#1191 implements acceptance test case.

@omegat-org omegat-org deleted a comment from github-actions bot Nov 19, 2024
Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/fhm3a5g6u3hvk

Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/25j2fhg37swbs

@miurahr miurahr force-pushed the topic/miurahr/aligner/fix-core-dependency branch from 28c0a3a to a47dc6b Compare November 19, 2024 22:59
@miurahr miurahr force-pushed the topic/miurahr/aligner/fix-core-dependency branch from a47dc6b to 75ed8c6 Compare November 19, 2024 23:03
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/mcenhsptdmu2i

Signed-off-by: Hiroshi Miura <[email protected]>
Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/xq2alopttjwnu

Copy link

❌ Quality checks failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/cq6rgkhbtnn5u

Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/2y6y4phdmpdwy

Copy link

❌ Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/fztovt6qnkufy

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr merged commit e383b05 into master Nov 21, 2024
13 checks passed
@miurahr miurahr deleted the topic/miurahr/aligner/fix-core-dependency branch November 21, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant