-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce Core dependency for aligner #1190
Conversation
#1191 implements acceptance test case. |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
28c0a3a
to
a47dc6b
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
a47dc6b
to
75ed8c6
Compare
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <[email protected]>
aligner/src/main/java/org/omegat/gui/align/AlignFilePickerController.java
Outdated
Show resolved
Hide resolved
aligner/src/main/java/org/omegat/gui/align/AlignFilePickerController.java
Outdated
Show resolved
Hide resolved
aligner/src/main/java/org/omegat/gui/align/AlignFilePickerController.java
Show resolved
Hide resolved
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
aligner/src/main/java/org/omegat/gui/align/AlignFilePickerController.java
Show resolved
Hide resolved
❌ Quality checks failed. Please look a Gradle Scan page for details: |
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <[email protected]>
❌ Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <[email protected]>
The Aligner depends on the Core configuration of segmentation and the filters.
It is not good to access Core API throughout the code, but it can be taken in ctor once.
Pull request type
refactor
What does this PR change?
Other information