Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter(po): plural as comment in japanese target #1165

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: filter(po): plural as comment in japanese target #1165

wants to merge 3 commits into from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Oct 23, 2024 •
edited
Loading

Japanese is nplural=1 language.
When there is no marker in singular msgid, translator can not see plural form of msgid when translate in OmegaT panes. This adds plural form of msgid as a comment of a segment which is a singular form.

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

  • Add plural form of msgid string as comment when singular msgid is a source
  • Refactoring to replace String concatenation with "+" into "StringBuilder"

Other information

ref: discussion on https://sourceforge.net/p/omegat/bugs/1269/

@miurahr
feat/filter(po): plural as comment in japanese
96c8e2f 
Japanese is nplural=1 language.
When there is no marker in singular msgid, translator can not see plural form of msgid when translate in OmegaT panes.
This add plural form of msgid as a comment of a segment which is a singular form.

Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@miurahr miurahr changed the title feat: filter(po): plural as comment in japanese feat: filter(po): plural as comment in japanese target Oct 23, 2024
@miurahr miurahr marked this pull request as ready for review October 24, 2024 09:50
@Kazephil
Fix typo in date
70bcc43 
Might as well fix this typo too while we're at it.
@miurahr miurahr added this to the 6.1.0 (Require Java 11) milestone Oct 30, 2024
brandelune
brandelune reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@brandelune brandelune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this modification will help the translator in the case at hand.
The resulting file will still trigger errors.

Also, in the case of plurals, their display location could be under the source, at the location of the alternative source.

@miurahr
Copy link
Member Author

miurahr commented Dec 4, 2024

Please provide a reproducible of the error. I observe the checker pass well.

@brandelune
Copy link
Contributor

Please provide a reproducible of the error. I observe the checker pass well.

I can’t do much at the moment. Give me some time.

@brandelune
Copy link
Contributor

Documentation ticket:
https://sourceforge.net/p/omegat/documentation/436/

@miurahr miurahr marked this pull request as draft February 22, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandelune brandelune brandelune left review comments

@Kazephil Kazephil Kazephil approved these changes

@kosivantsov kosivantsov Awaiting requested review from kosivantsov kosivantsov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0 (Require Java 11)
Development

Successfully merging this pull request may close these issues.
3 participants
@miurahr @brandelune @Kazephil