Replace OOC libturbojpeg with post-10.9 sdk build #4269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osx_64/libturbojpeg.dylib was built with an SDK older than 10.9, which brings it out of compliance with Apple security requirements and results in notarization failures. This replaces the outdated dynamic library file with a newer one built from https://github.com/libjpeg-turbo/libjpeg-turbo
|
Hi @RR-N. Thanks for taking the time to open a PR. However, similar to the statement in https://ome-contributing.readthedocs.io/en/latest/third-party-policy.html#proprietary-native-code-blobs we cannot take any contributions that introduce third-party-built code artifacts such as dynamic or statically linked libraries. The path to seeing this integrated would be a build system which can be run by the maintainers (e.g., at https://ci.openmicroscopy.org/). Before you embark on that, however, I'd suggest reading https://forum.image.sc/t/bio-formats-update/101734 in terms of the available capacity to review large or complex PRs. I'm closing this PR but happy for the conversation to continue at #4170 Best, See also: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
osx_64/libturbojpeg.dylib was built with an SDK older than 10.9, which brings it out of compliance with Apple security requirements and results in notarization failures for bundles featuring the bioformats package. See #4170.
Solution:
This PR replaces the outdated dynamic library file with a newer one built from the source on the main libjpeg_turbo repository.