Skip to content

Exclude merckmillipore.com from link check #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dominikl
Copy link
Member

Since a few days the URL check for https://www.merckmillipore.com is failing with 403, but works manually in the browser. This PR just adds it to the exclude list for the link check.

(formats/amnis-flowsight: line   10) broken    https://www.merckmillipore.com/ - 403 Client Error: Forbidden for url: https://www.merckmillipore.com/

( https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/421/console )

@dominikl dominikl requested a review from pwalczysko April 29, 2025 13:00
@melissalinkert
Copy link
Member

Note this doesn't fix the linkcheck build (https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/422/), as the link doesn't have a trailing slash (https://github.com/ome/bio-formats-documentation/blob/master/src/main/resources/format-pages.txt#L99).

Either a trailing slash needs to be added to the link so the current exclude picks it up, or the exclude needs to be something like https://www.merckmillipore.com*. There are several examples of the latter approach earlier in the exclude list.

@dominikl
Copy link
Member Author

dominikl commented May 1, 2025

Ah yes of course, thanks Melissa!

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants