Repository navigation
Remove the systemd-boot entries the ISO never ships - #369
Merged
Merged
Conversation
[Low impact] The PR appears safe to merge; the removed files are unused by the selected boot modes, and the updated test passes. SummaryRemoves two unused systemd-boot configuration files and updates the boot test to stop searching their deleted directory.
Reviews (2) · Last reviewed commit: "Remove the systemd-boot entries the ISO ..." · Reviewed by Greptile |
configs/efiboot/ holds systemd-boot loader entries, but profiledef.sh selects only bios.syslinux and uefi.grub. mkarchiso never copies them into the ISO, so nothing builds or boots them. The entry is also stale: it names vmlinuz-linux-t2, while the live kernel is linux-omarchy, with linux-t2 only on Apple firmware (configs/grub/grub.cfg). A reader who looks for the live boot config finds a dead file that disagrees with the one in use. Delete the directory and drop it from the paths boot-cmdline-test.sh scans. That test still finds 11 entries across syslinux, GRUB and the loopback config, above its minimum of 9.
This comment has been minimized.
This comment has been minimized.
emirb
force-pushed
the
boot/drop-dead-efiboot-config
branch
from
October 30, 2026 22:20
7a1f898 to
294095f
Compare
Install test passed
Boots are loader, kernel and userspace, without the VM's firmware. Install phases, x86_64
Install phases, aarch64
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
configs/efiboot/holds systemd-boot loader entries. As the profile stands,configs/profiledef.shselectsbootmodes=('bios.syslinux' 'uefi.grub')on x86_64 and('uefi.grub')on aarch64, so mkarchiso never reads the directory and never copies it into the ISO. Nothing builds or boots these entries.The entry is also stale: it names
vmlinuz-linux-t2, but the live kernel islinux-omarchy(build-iso.sh:8,configs/grub/grub.cfg:55), withlinux-t2only on firmware that reports Apple Inc. A reader who looks for the live boot config finds a dead file that disagrees with the one in use.Fix
Delete
configs/efiboot/and drop the directory from the pathstest/unit/boot-cmdline-test.shscans. The test keeps every assertion on the entries that do ship.The alternative was to update the dead entry to
linux-omarchy. That keeps a second, unreachable copy of the boot config, and it will drift again the next time the live kernel changes. Deleting it removes the special case instead.Scope and risk
The ISO's boot behaviour does not change, because mkarchiso never read these files. The only changes are two deleted dead files and the path list in one unit test. The boot paths that matter,
configs/grub/andconfigs/syslinux/, are untouched.To undo, restore the two deleted files.
Evidence
test/unit/boot-cmdline-test.shpasses: 11 entries across syslinux, GRUB and the loopback config pincopytoram=nandinitramfs_options=size=90%, above the test's minimum of 9. A repo-wide search finds no remaining reference toconfigs/efiboot.Not verified: a full ISO build. The change removes files mkarchiso never reads, so the build input is unchanged.