Repository navigation
ci: build the team's pull requests on every push - #208
Merged
Merged
Conversation
The team's pull requests got checks only until a maintainer applied ci:build, and on a fork the label had to be applied again after every push. Most of the team works from forks. Add .github/VOUCHED.td, listing the current repository collaborators, in the mitchellh/vouch format omarchy-pkgs uses. A pull request whose author is listed there or is a collaborator now gets a full run on every push once it is out of draft, forks included. A denounced author gets checks only, whatever their access or labels. The plan job reads the list from the target branch through the API, so a pull request cannot vouch for its own author. Build reuse is unchanged: pull request runs are still never a source of packages or verification records, so the merge queue builds and attests as before. Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
[Medium impact] The PR appears safe to merge; the previous list-test issue is fixed and no new actionable issues were found. SummaryTeam pull requests get full builds on each non-draft update when both the author and sender are vouched for.
|
GitHub holds every run of a pull request from an outside collaborator until a maintainer approves it, so joshuaswarren's pull requests could not build on their own even once vouched for. kernel-ci-approve.yml runs on pull_request_target with only the target branch's files and approves the held kernel-ci.yml run of the current head when the author is vouched for. Anyone else's runs stay held. Add joshuaswarren to the list, and stop trusting author_association: the omacom organization has members outside the kernel team, and they should not get builds without being listed. Require the pusher to be vouched for too, so no one outside the team can push to a team member's pull request and have it built or approved. Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
The repository list test required every entry to be a vouch, so adding a documented "-github:<login> <reason>" line would have failed CI. Check the format, the reason, sorting and duplicates for both kinds. Signed-off-by: Marcelo Alcantara <maralc@gmail.com>
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRs from the kernel team (
.github/VOUCHED.td) now build (package, KUnit, boot) on every push, forks included, with noci:buildlabel. Everyone else, including omacom org members not on the list, gets checks only, as before.VOUCHED.tdlists 16 people: the 15 current collaborators plus joshuaswarren. Org or repo access alone no longer counts, because 17 omacom org members aren't on the kernel team.Unchanged: PR runs are still never a source of reused packages or verification records, so the merge queue builds and attests as before.
Evidence
plan.py+ approval rule:full; joshuaswarren's held runs get auto-approved; drafts waitlight, held for a maintainerfull, the 17 unlisted oneslightMerge Danger
Door: two-way
Revert, or edit
VOUCHED.td.Blast Radius: CI cost
More Namespace builds: one per push on each non-draft team PR. The new
pull_request_targetworkflow hasactions: writebut runs only the target branch's code. It depends on the "require approval for all outside collaborators" setting staying on.