Repository navigation
tests: asahi: scan default T6030 trees for PMP compatibles - #206
Merged
maralcbr merged 1 commit intoOct 28, 2026
Merged
Conversation
The display gate refuses any existing PMP or report compatible anywhere in the tree, including disabled nodes. The DT control only checks four names under /soc, so renamed or nested nodes can pass it and still block the runtime PMP overlay. Walk the whole default-profile tree and reject either compatible in any entry of each compatible string list. Keep the existing static-profile node and alias checks. Compare case-insensitively, as the OF lookup does. Link: #202 (comment) Signed-off-by: Chris Kearney <303316+chriskearney@users.noreply.github.com> Generated-by: LLM
[Low impact] This test-only change appears safe to merge. SummaryAdds a whole-tree check for static PMP compatibles in the default T6030 device trees.
Reviews (1) · Last reviewed commit: "tests: asahi: scan default T6030 trees f..." · Reviewed by Greptile |
maralcbr
approved these changes
Oct 28, 2026
maralcbr
left a comment
Member
There was a problem hiding this comment.
@chriskearney looks good. check_default_compatibles() (t6030-pmp-dt-tests.py:21-43) walks every node from /, splits each compatible list on NUL, and lowercases before it matches. That's how the gate looks for a PMP node too: the whole tree, disabled nodes included, case-insensitive like of_compat_cmp(). It runs only for the default profile. The static profile still expects its four nodes, and the alias check hasn't changed.
Small things I checked:
- On a node with no
compatible,fdtget -d ""prints a blank line, soraw.split()is empty and the node passes. - The path join handles the root (
"/".rstrip("/") + "/" + child). - It's two
fdtgetcalls for every node it visits, over two default-profile DTBs. That's fine for a host test.
Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Marcelo’s follow-up on #202.
A renamed or nested static PMP node can pass the existing default-profile test while still making the display gate refuse startup. Scan the entire tree for
apple,t6000-pmp-v2andapple,t6030-pmp-v2-report, including disabled nodes and every entry in a compatible list. Matching is case-insensitive, as in the OF lookup. The existing static-profile node and alias checks remain.Validation:
/soc, and nested disabled nodes with fallback compatibles, including mixed case.checkpatch --strict: no findings on the code diff.This is test-only hardening. It does not claim the separate final-artifact cold-boot or display-disabled hardware qualification requested before release. Implementation and validation assisted by Codex.