Skip to content

media: apple: isp: restore J613 camera capture on 14.7 firmware #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maralcbr merged 2 commits into from
Oct 24, 2026
Merged

media: apple: isp: restore J613 camera capture on 14.7 firmware #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b34040
media: apple: isp: correct the T8122 PMU base address
garymeyerca Oct 16, 2026
4433ef5
media: apple: isp: use temporal filter zero on J613 firmware 14.7
garymeyerca Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion drivers/media/platform/apple/isp/isp-drv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,18 @@
if (err)
isp->temporal_filter = 0;

/* J613 firmware 14.7 stalls capture with temporal filter 1. */
if (of_machine_is_compatible("apple,j613") &&
isp->fw_compat == ISP_FIRMWARE_V_14_7 &&
isp->temporal_filter == 1) {
dev_info(dev, "using temporal filter 0 on J613 firmware 14.7\n");

@maralcbr maralcbr Oct 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this gates on ISP firmware-compat, not the OS firmware version, so "firmware-compat 14.7" here and in the comment at :424 would be more precise.

isp->temporal_filter = 0;
}

err = apple_isp_init_presets(isp);
if (err) {
dev_err(dev, "failed to initialize presets\n");
goto free_isp;

Check warning on line 435 in drivers/media/platform/apple/isp/isp-drv.c

View workflow job for this annotation

GitHub Actions / ci / commits

checkpatch NO_AUTHOR_SIGN_OFF (4433ef5a0ded) 

Missing Signed-off-by: line by nominal patch author 'garymeyerca <220751193+garymeyerca@users.noreply.github.com>'
}

err = apple_isp_attach_genpd(isp);
Expand Down Expand Up @@ -670,11 +678,11 @@
.scl1 = true,
.lpdp = true,
.meta_size = ISP_META_SIZE_T8112,
};

Check warning on line 681 in drivers/media/platform/apple/isp/isp-drv.c

View workflow job for this annotation

GitHub Actions / ci / commits

checkpatch NO_AUTHOR_SIGN_OFF (6b3404044e17) 

Missing Signed-off-by: line by nominal patch author 'garymeyerca <220751193+garymeyerca@users.noreply.github.com>'

static const struct apple_isp_hw apple_isp_hw_t8122 = {
.gen = ISP_GEN_T8112,
.pmu_base = 0x2d07040000,
.pmu_base = 0x2d0704000,

@maralcbr maralcbr Oct 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right: PMGR 0x2d0700000 + ps_isp_set0 0x4000. Could the commit carry Fixes: f26396997e09 ("media: apple: isp: add t8122 support")?


.dsid_count = 1,
.dsid_clr_base0 = 0x2221c4000,
Expand Down
Loading