Exclude install media from disk picker#73
Open
mplaczek99 wants to merge 2 commits intoomacom-io:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exclude the live install media from the Omarchy ISO disk picker.
Closes basecamp/omarchy#5167
The configurator was trying to hide the boot device by reading the mount source
for
/run/archiso/bootmnt, but that source is usually a partition like/dev/sda1while the installer presents whole disks like/dev/sda.That mismatch let the USB installer disk stay in the list, where it could be
selected and wiped by mistake.
What changed
get_root_disk()to walk a device back to its parent disk/run/archiso/bootmntto the root disk before filtering candidatesVerification
bash -n configs/airootfs/root/configuratorlsblkchecks confirming/dev/sda1 -> /dev/sda