Add systemd hooks support to ISO installer (companion to omarchy#3014)#60
Draft
d-cas wants to merge 3 commits intoomacom-io:mainfrom
Draft
Add systemd hooks support to ISO installer (companion to omarchy#3014)#60d-cas wants to merge 3 commits intoomacom-io:mainfrom
d-cas wants to merge 3 commits intoomacom-io:mainfrom
Conversation
After archinstall completes, convert the kernel cmdline from busybox syntax (cryptdevice=PARTUUID=...:root) to systemd syntax (rd.luks.name=<uuid>=root) to match the systemd hooks installed by the omarchy repo's fix/modernize-initramfs-hooks branch. The fix_kernel_cmdline_for_systemd() function: - Detects LUKS encrypted installations - Extracts PARTUUID from Limine config - Gets LUKS UUID from the device - Replaces kernel cmdline syntax - Creates backup of original config This fixes boot hangs where systemd's sd-encrypt hook can't unlock the root device due to incompatible cmdline syntax.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the ISO installer to be compatible with the systemd-based initramfs hooks proposed in basecamp/omarchy#3014.
Problem
archinstall(used by the Omarchy ISO) generates BusyBox-style kernel cmdline parameters (cryptdevice=PARTUUID=...), but systemd hooks require systemd-style parameters (rd.luks.name=...).Without this fix, new installations using systemd hooks would fail to boot.
Changes
fix_kernel_cmdline_for_systemd()function to.automated_script.shcryptdevice=PARTUUID=<uuid>:root→rd.luks.name=<uuid>=rootContext
This PR is a companion to basecamp/omarchy#3014, which proposes migrating to systemd-based initramfs hooks to enable:
As discussed in basecamp/omarchy#3014, whether this migration makes sense for Omarchy depends on whether the benefits (TPM2/FIDO2 support) outweigh the migration complexity for the existing user base.
This PR simply ensures that if the systemd hooks migration is accepted, new ISO installations will work correctly.
Testing
rd.luks.name=<uuid>=rootsd-encrypt,sd-vconsole,sd-btrfs-overlayfsStatus
DRAFT. Companion to experimental basecamp/omarchy#3014
d-cas/omarchy:fix/modernize-initramfs-hooksbasecamp/omarchy:masterbefore mergeNotes
bin/omarchy-iso-makecurrently points to the testing branch for integration testing.If merged, this should be updated to pull from
basecamp/omarchy:dev.