Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic edgetx/elrs bind start #301

Closed
wants to merge 1 commit into from
Closed

mimic edgetx/elrs bind start #301

wants to merge 1 commit into from

Conversation

olliw42
Copy link
Owner

@olliw42 olliw42 commented Mar 5, 2025

@jlpoltrack
this might be something to test out
it makes mLRS tell EdgeTx it is ELRS, such that EdgeTx should show the bind button in the crsf setup page. Pressing the bind button should put the tx module into bind mode indeed

this is not for merge but to test if this is working, so we eventually could consider doing a change to EdgeTx to get a bind button also for mLRS. (mLRS does not have an unbind mechanism, so this would work differently)

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Mar 5, 2025

it makes mLRS tell EdgeTx it is ELRS, such that EdgeTx should show the bind button in the crsf setup page.

Flashed BetaFPV Micro with this branch, don't see Bind button on the Model Setup > External RF Page with EdgeTx 2.11

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Mar 5, 2025

Would need to fake the version number as well - I see the check here is for version >= 3.4 https://github.com/EdgeTX/edgetx/blob/978532429289c5675bb396d68fae90d2faab6bfc/radio/src/gui/gui_common.cpp#L1262-L1265 to get the bind button to show up

Edit - so if I fake the VERSION to 99999 then the Bind and Arm Using options show up. Selecting Bind does put the Tx module in binding mode, so that part works.

@olliw42
Copy link
Owner Author

olliw42 commented Mar 5, 2025

great. THX.
the button should change to 'unbind' when pressed ... when you press it again the tx module should stop the bind mode ... does this work too?

@jlpoltrack
Copy link
Collaborator

When I select the button to bind, the message on the button remains bind. If I select the button again, then the module does a soft reboot.

@olliw42
Copy link
Owner Author

olliw42 commented Mar 5, 2025

yes, that's the behavior
so, I guess we can add the basic functionality, to be prepared for some addition to edgetx
THX!

@olliw42 olliw42 closed this Mar 6, 2025
@olliw42 olliw42 deleted the owpr-edgetxbind branch March 7, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants