Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx, crsf, send device info upon ping device #298

Merged
merged 6 commits into from
Mar 4, 2025
Merged

tx, crsf, send device info upon ping device #298

merged 6 commits into from
Mar 4, 2025

Conversation

olliw42
Copy link
Owner

@olliw42 olliw42 commented Mar 3, 2025

attempt to account for #297

not tested, just did some code

@jlpoltrack maybe you find a chance to test this out :)

@jlpoltrack
Copy link
Collaborator

Not working at the moment. This appears to send as a 'Broadcast Frame' but needs to be sent as a 'Extended Header Frame' with the addresses.

image

image

@jlpoltrack
Copy link
Collaborator

Got it working, will PR to your branch.

jlpoltrack and others added 2 commits March 3, 2025 19:00
* working

* original device name

* fix location
@olliw42
Copy link
Owner Author

olliw42 commented Mar 3, 2025

@jlpoltrack
MANY thx for your PR :)
added it, and tidied it up
could you pl double check/test again?

It seems that EdgeTx cuts the name down to 15 chars max ... what do you see actually displayed now?
how many chars? is there some version info?

@olliw42
Copy link
Owner Author

olliw42 commented Mar 3, 2025

I guess it would be nice if we also could get the bind button LOL

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Mar 3, 2025

could you pl double check/test again?

Still working :)

It seems that EdgeTx cuts the name down to 15 chars max ... what do you see actually displayed now?

In Settings > Version > Modules I see the string 'MLRS BetaFPV Mi V40.0.0'. For the version, the closest that I can get is to send '0x05030100' which results in V1.3.5' on the radio (but can't quite see an easy way to convert the VERSION to that).

@olliw42
Copy link
Owner Author

olliw42 commented Mar 3, 2025

thx
so, we probably want to not add the MLRS at the beginning of th ename, I guess
concerning the version, I was wondering if it is part of the name, or generated from the firmwareid field, looks like it's generated ...

@jlpoltrack
Copy link
Collaborator

Well IMO probably doesn't need to be perfect, it's rather buried in the settings. I had to look at the EdgeTx source to figure out where this would be...

@olliw42
Copy link
Owner Author

olliw42 commented Mar 4, 2025

@jlpoltrack
added some code to - hopefully - do the version correctly.
also stripped the name
Could you pl test?

also did the serial_no ... EdgeTx seems to use it to identfy ELRS modules, so, we could use the same mechanism to - maybe at some point - make EdgeTx to identify mLRS, e.g., to also give us a bind button
https://github.com/EdgeTX/edgetx/blob/main/radio/src/telemetry/crossfire.cpp#L295-L296

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Mar 4, 2025

added some code to - hopefully - do the version correctly.

Yea, looks good. Shows 'V1.3.5'

@olliw42
Copy link
Owner Author

olliw42 commented Mar 4, 2025

so, ready to merge?

@jlpoltrack
Copy link
Collaborator

Yea, good to merge.

@olliw42
Copy link
Owner Author

olliw42 commented Mar 4, 2025

many thx, sir

@olliw42 olliw42 merged commit 30b6194 into main Mar 4, 2025
@olliw42 olliw42 deleted the owpr-edgetx211 branch March 4, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants