Models are not being included on delete method.

[ivatra]

Description

When you try to execute delete method with "include" param, function createDeleteParams doesn't consider it.

Query

 const res = await prisma.key.delete({
    where: {
      id: 6
    },
    include: {
      game: true,
      manager: true,
    },
  });

Actual query results

{
  id: 6,
  managerId: 3,
  gameId: 10,
  deletedAt: 2023-12-27T01:57:28.486Z
}

Expected query results

{
  id: 6,
  managerId: 3,
  gameId: 10,
  deletedAt: 2023-12-27T01:58:15.158Z,
  game: { ... },
  manager: {
    ...
  }
}

Solution

It can be fixed easily by adding ...params.args to returning params object in createDeleteParams. Or you may explicitly pass params.args.include so be sure unconsidered data won't be in params.

Environment

Prisma-soft-delete-middleware version: 1.1.2
Prisma version: 5.2.0
Node.js version: 18.12.1

[olivierwilkinson]

Hi there,

Thanks for raising this, you are totally right that this is broken! I've made some adjustments so we only spread for a top level delete rather than a nested delete, spreading in the nested delete case was causing some test failures.

I've also added some extra test cases to be sure I didn't miss other places where you can include.

It's passing the tests now so LGTM!

I'll have a look at your other PR later on today 🙌

[github-actions]

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀