This repository was archived by the owner on Oct 20, 2023. It is now read-only.
fix uncle blokcs are orphaned #1574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix uncle blokcs are orphaned when block.ConfirmationProgress > 0.75
This was referenced Jan 3, 2023
fix matchUncle
Owner
|
As I currently do not have an ETC pool, could someone comment on how effective this fix is? |
Contributor
|
I think the logic makes sense, even though I never encountered that issue. But maybe I just got lucky. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the perspective of the integrity of the program code, conitnue is missing when confirming the uncle block, which leads to the wrong entry of if block.ConfirmationProgress > 0.75 , cause uncle blocks to become orphan blocks