Skip to content

Refactor unit initialization and update dependencies #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olbrich merged 3 commits into from
Dec 26, 2025
Merged

Refactor unit initialization and update dependencies #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be7f778
Refactor unit initialization for improved clarity and structure
olbrich Dec 26, 2025
b353362
Enhance caching logic and add comprehensive initialization tests
olbrich Dec 26, 2025
378fbbd
Merge branch 'master' into refactor-initialize
olbrich Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/ruby_units/cache.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def get(key)
# @return [void]
def set(key, value)
key = key.to_unit.units unless key.is_a?(String)
return if should_skip_caching?(key)

data[key] = value
end

Expand All @@ -32,5 +34,9 @@ def keys
def clear
@data = {}
end

def should_skip_caching?(key)
keys.include?(key) || key =~ RubyUnits::Unit.special_format_regex
end
end
end
Loading