Repository navigation
fix: append observations for duplicate entities in AddObservations - #6
Merged
Merged
Conversation
AddObservations silently lost data when the same entity appeared twice in the input array — the map assignment overwrote the first entry's observations. Use append to accumulate all observations per entity. Fixes #3 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes a data-loss bug in KnowledgeGraphManager.AddObservations where multiple ObservationAddition entries for the same entity would overwrite earlier observations instead of accumulating them.
Changes:
- Update
AddObservationsto append observations per entity rather than overwrite the per-entity map entry. - Add a regression test to ensure duplicate-entity additions preserve all observations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
main.go |
Accumulates observations for duplicate entities using append() when building the per-entity observation map. |
main_test.go |
Adds TestAddObservationsDuplicateEntity to verify observations from duplicate-entity additions are all retained. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Thanks for this fix, @tekicode! 🎉 Great catch on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddObservationssilently lost data when the same entity appeared twice in the input array — the map assignment (=) overwrote the first entry's observationsappend()so all observations accumulate per entityTestAddObservationsDuplicateEntityregression test inmain_test.goTest plan
ObservationAdditionentries for same entity with[obs-a, obs-b]and[obs-c, obs-d], asserts all 4 preservedmake check && go test ./... && make buildpasses cleanFixes tekicode#3
🤖 Generated with Claude Code