Repository navigation
refactor(core): split FocDriver and PhaseManager into modules - #7
Merged
Merged
Conversation
The driver and phase manager had grown into single files of several thousand lines, which made the hot path and the mode arms hard to review. Move them into directories without changing control behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
okhsunrog
force-pushed
the
refactor/split-foc-modules
branch
from
October 19, 2026 17:55
8f9027a to
5c49a16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
FocDriverandPhaseManagerinto modules so the hot path and the mode arms can be reviewed on their own. Control behavior is unchanged, and the public paths stay the same.foc_driver: driver, step, modes, protection, failsafe, and current-offset calibrationphase/manager: constructors, accessors, hall health, the commutation tracker, source selection, and thePhaseProviderimplstep()sequences named helpers that stay inlined on the ISR entry pointsMade with Cursor