Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/6 mobile friendly #14

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Feature/6 mobile friendly #14

merged 8 commits into from
Jan 17, 2025

Conversation

okaziya
Copy link
Owner

@okaziya okaziya commented Jan 15, 2025

Resolves #6

Copy link
Collaborator

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice adjustments! What an improvement. 😎

I found something that looks like a styling bug on both iPhone-Safari and Android-Chrome; there's something (invisible) that creates horizontal scroll bars on both platforms. Would be much nicer if those would disappear!

IMG_2501 Large

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On desktop it looks really nice as it is! When looking at the header in mobile mode, I think that the top 3 centimeters of the screen looks quite cramped. When in mobile-portrait mode, I think it would look better if the "Ladda ner CV" text was abbreviated to "PDF" or "PDF ⬇️" or "⬇️". Probably it would be better if dropping the sun glasses too, on mobile. What does @mkl-adsn think?

IMG_2498 Large

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about that?

Skärmavbild 2025-01-16 kl  16 05 48

Copy link
Collaborator

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horizontal scroll bars gone! ✅ See Mikael's text message that I shared on Telegram. A PDF download icon would probably improve the looks on mobile! 💐

@okaziya okaziya merged commit 9366627 into main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make website design responsive/mobile-friendly
2 participants