-
-
Notifications
You must be signed in to change notification settings - Fork 757
feat(completions/jump): add completion for jump #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
This commit updates the plugin's README to indicate that enabling the completion is an optional part of using the jump plugin.
In this particular case, follow the one concerning functions defined by a specific plugin.
akinomyoga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now noticed that the indentation is made with TAB, but I use two spaces in this repository. Could you update the indentation?
@akinomyoga fixed. |
|
@matlads Thanks! I've merged the PR! |
User description
This PR adds completion for the jump command, and updates the plugin documentation appropriately
PR Type
Enhancement
Description
Add bash completion support for jump command
Update jump plugin documentation with installation steps
Include usage instructions and completion configuration
Diagram Walkthrough
File Walkthrough
jump.completion.sh
Add bash completion for jumpcompletions/jump.completion.sh
compgenREADME.md
Update jump plugin documentationplugins/jump/README.md