Add omb version #621
Open
Add omb version #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
Oct 4, 2024
Contributor
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
Couldn't version=$(cmd1) || version=$(cmd2) || ... be combined to version=$(cmd1 || cmd2 || ...) to reduce the number of forks? Or is there cases where the output is produced yet should be discarded when the command fails?
| # 2) try branch name | ||
| # 3) try name-rev (tag~<rev> or branch~<rev>) | ||
| local version | ||
| version=$(command git -C "$OSH" describe --tags HEAD 2>/dev/null) \ |
Contributor
There was a problem hiding this comment.
Suggested change
| version=$(command git -C "$OSH" describe --tags HEAD 2>/dev/null) \ | |
| version=$(command git --git-dir="$OSH" describe --tags HEAD 2>/dev/null) \ |
See #311 for details. Sadly, CentOS was discontinued, yet many large systems continue to stay in CentOS 7. The same for the other occurrences of -C "$OSH"
Comment on lines
+33
to
+35
| # 1) try tag-like version | ||
| # 2) try branch name | ||
| # 3) try name-rev (tag~<rev> or branch~<rev>) |
Contributor
There was a problem hiding this comment.
Is the branch name useful to identify the version? A branch name is a moving target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
omb versionto attempt to retrieve the version of oh-my-bash using git.