Skip to content

Implement omb theme #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RobLoach wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Implement omb theme #620

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f419dbe
plugins: Add Theme plugin
RobLoach Oct 2, 2024
2eccd63
Move to Usage: omb theme <command>
RobLoach Oct 2, 2024
be83204
Update lib/cli.bash
RobLoach Oct 2, 2024
e4940e1
Apply suggestions from code review
RobLoach Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions lib/cli.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,43 @@ function _omb_cmd_reload {
echo 'Not yet implemented'
}
function _omb_cmd_theme {
echo 'Not yet implemented'
case "$1" in
list)
local -a available_themes
_comp_cmd_omb__get_available_themes
for theme in "${available_themes[@]}"; do
echo "$theme"
done
;;
use)
local theme=$2
if [[ -z "$theme" ]]; then
echo 'Usage: omb theme use <theme>'
return 2
fi
local -a available_themes
_comp_cmd_omb__get_available_themes
for i in "${available_themes[@]}"; do
if [ "$i" == "$theme" ]; then
_omb_module_require_theme "$theme"
Copy link
Contributor

@akinomyoga akinomyoga Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_omb_module_require_theme is kind of "include once"; it checks whether the module is already loaded and loads the module only when it hasn't been loaded. So, with this implementation, one cannot switch to the theme that was loaded before.

To handle this, we may need to factorize a part of _omb_module_require (oh-my-bash.sh) into _omb_module_search and use it to obtain the location of the theme file.

return 0
fi
done
echo "Theme '$theme' not found"
;;
set)
echo 'Not yet implemented'
;;
*)
echo 'Usage: omb theme <command>'
echo ''
echo 'Available commands:'
echo ' list List all available themes'
echo ' set <theme> Set the given theme in your .bashrc file'
echo ' use <theme> Load the given theme'
return 2
;;
esac
}
function _omb_cmd_update {
echo 'Not yet implemented'
Expand Down Expand Up @@ -161,7 +197,7 @@ function _comp_cmd_omb {
theme)
local -a subcmds=(
'list:List themes'
'set:Set a theme in your .zshrc file'
'set:Set a theme in your .bashrc file'
'use:Load a theme'
)
_comp_cmd_omb__describe 'command' subcmds ;;
Expand Down