fix(skills): quote argument-hint flow sequence in pr-ready frontmatter (#850) - #911
Conversation
s-annam
left a comment
There was a problem hiding this comment.
Verdict: APPROVE (0 Blocking, 0 Secondary, 0 Nits)
Exact fix for #850: quotes argument-hint in .claude/skills/pr-ready/SKILL.md so it parses as a plain string instead of an invalid unquoted YAML flow sequence. Verified locally — yaml.safe_load on the frontmatter now parses clean (previously errored expected ',' or ']', but got '[').
Gates
- 3a (fixture PII): N/A, no fixtures touched.
- 3b (design-system/reuse): N/A, no
src/componentstouched. - 3c (style tokens): N/A.
- 3d (fallow/dead-code): N/A, no exports touched.
- 3e (command-level bugs in skill file): change is a pure frontmatter quoting fix, no
gh/bash commands altered — no new command bugs introduced. - 3f (description accuracy): body is accurate; "Verified YAML frontmatter parses cleanly" checks out.
AC checklist (#850)
- Quote the
argument-hintvalue → done, matches the issue's suggested fix verbatim. - Issue's "Suggested follow-up" (a mechanical frontmatter-parse check across all skills) is explicitly optional and out of scope for this PR — not required here.
Note (out of scope, not a finding against this PR)
Ran the same YAML sweep across all .claude/skills/*/SKILL.md out of curiosity: probe-jobs/SKILL.md also fails to parse (mapping values are not allowed here) on main today. That's pre-existing and unrelated to this diff — worth its own issue if the follow-up sweep from #850 is ever picked up, but not this PR's problem.
Head reviewed: 9d5c4fb16d002bc89945fa56a5e23e29bb4ec4f9
Reviewed by: Claude Sonnet 5 (high)
Summary
Fixes #850.
Quotes the
argument-hintvalue in.claude/skills/pr-ready/SKILL.mdfrontmatter so that it is parsed as a valid string rather than an invalid unquoted YAML flow sequence.Changes
.claude/skills/pr-ready/SKILL.md:argument-hint: "[<pr-number>[,<pr-number>...]]"Verification