Skip to content

fix(skills): quote argument-hint flow sequence in pr-ready frontmatter (#850) - #911

Merged
s-annam merged 1 commit into
offlinecv:mainfrom
shubhransh-gupta:fix/pr-ready-frontmatter-yaml
Aug 27, 2026
Merged

fix(skills): quote argument-hint flow sequence in pr-ready frontmatter (#850)#911
s-annam merged 1 commit into
offlinecv:mainfrom
shubhransh-gupta:fix/pr-ready-frontmatter-yaml

Conversation

@shubhransh-gupta

Copy link
Copy Markdown
Contributor

Summary

Fixes #850.

Quotes the argument-hint value in .claude/skills/pr-ready/SKILL.md frontmatter so that it is parsed as a valid string rather than an invalid unquoted YAML flow sequence.

Changes

  • .claude/skills/pr-ready/SKILL.md: argument-hint: "[<pr-number>[,<pr-number>...]]"

Verification

  • Verified YAML frontmatter parses cleanly without syntax errors across strict YAML parsers.

@s-annam s-annam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE (0 Blocking, 0 Secondary, 0 Nits)

Exact fix for #850: quotes argument-hint in .claude/skills/pr-ready/SKILL.md so it parses as a plain string instead of an invalid unquoted YAML flow sequence. Verified locally — yaml.safe_load on the frontmatter now parses clean (previously errored expected ',' or ']', but got '[').

Gates

  • 3a (fixture PII): N/A, no fixtures touched.
  • 3b (design-system/reuse): N/A, no src/components touched.
  • 3c (style tokens): N/A.
  • 3d (fallow/dead-code): N/A, no exports touched.
  • 3e (command-level bugs in skill file): change is a pure frontmatter quoting fix, no gh/bash commands altered — no new command bugs introduced.
  • 3f (description accuracy): body is accurate; "Verified YAML frontmatter parses cleanly" checks out.

AC checklist (#850)

  • Quote the argument-hint value → done, matches the issue's suggested fix verbatim.
  • Issue's "Suggested follow-up" (a mechanical frontmatter-parse check across all skills) is explicitly optional and out of scope for this PR — not required here.

Note (out of scope, not a finding against this PR)

Ran the same YAML sweep across all .claude/skills/*/SKILL.md out of curiosity: probe-jobs/SKILL.md also fails to parse (mapping values are not allowed here) on main today. That's pre-existing and unrelated to this diff — worth its own issue if the follow-up sweep from #850 is ever picked up, but not this PR's problem.

Head reviewed: 9d5c4fb16d002bc89945fa56a5e23e29bb4ec4f9


Reviewed by: Claude Sonnet 5 (high)

@s-annam
s-annam added this pull request to the merge queue Aug 27, 2026
Merged via the queue into offlinecv:main with commit 74b96e5 Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr-ready SKILL.md frontmatter is invalid YAML (unquoted argument-hint flow sequence)

2 participants