Conversation
5 tasks
Extract PerBulletFeedback, BulletRow, and needsAttention out of Result.tsx (was inline, 167 lines) into a new feature component at src/components/features/PerBulletFeedback.tsx (267 lines). Redesign the flat table as a drill-down model: - Rollup summary row: total bullets + per-check pass/fail counts - Bullets grouped by failure category (missing metric / length / verb) - Categories ordered worst-first (most failing bullets first) - Within each category bullets sorted by most checks failed (descending) - Each category wrapped in a native <details>/<summary> disclosure, collapsed by default so passing sections stay out of the way - Passing bullets counted in the summary but not rendered at full weight Result.tsx drops from ~480 to ~320 LOC and imports the component as a single line; no logic was changed in the scoring or parsing pipeline. Resolves #38
Replace the per-failure-mode <details> grouping with a single resume-ordered list: each failing bullet appears exactly once (was duplicated across categories). Failed-check chips and the rewrite trigger sit inline on the bullet's own line, keeping each row compact. RewriteButton's idle trigger drops from a bordered block under every bullet to a low-weight inline "Rewrite" text-link with an SVG sparkle (no emoji), 44px tap target, aria-label. Rendered on failing bullets only — passing bullets are counted, not buttoned. Panels/engine/ telemetry unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
s-annam
added a commit
that referenced
this pull request
Jun 15, 2026
…49) Extract PerBulletFeedback out of Result.tsx into its own feature component. Flatten the per-failure-mode grouping into a single resume-ordered list (each failing bullet once); failed-check chips + the WebLLM rewrite trigger sit inline on each bullet's line. RewriteButton idle trigger slimmed to a low-weight inline "Rewrite" text-link (SVG sparkle, 44px tap, aria-label), failing bullets only. Rebased onto main; verify CI green; 243 tests pass. Resolves #38 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
s-annam
added a commit
that referenced
this pull request
Jun 25, 2026
…49) Extract PerBulletFeedback out of Result.tsx into its own feature component. Flatten the per-failure-mode grouping into a single resume-ordered list (each failing bullet once); failed-check chips + the WebLLM rewrite trigger sit inline on each bullet's line. RewriteButton idle trigger slimmed to a low-weight inline "Rewrite" text-link (SVG sparkle, 44px tap, aria-label), failing bullets only. Rebased onto main; verify CI green; 243 tests pass. Resolves #38 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
s-annam
added a commit
that referenced
this pull request
Jun 28, 2026
…49) Extract PerBulletFeedback out of Result.tsx into its own feature component. Flatten the per-failure-mode grouping into a single resume-ordered list (each failing bullet once); failed-check chips + the WebLLM rewrite trigger sit inline on each bullet's line. RewriteButton idle trigger slimmed to a low-weight inline "Rewrite" text-link (SVG sparkle, 44px tap, aria-label), failing bullets only. Rebased onto main; verify CI green; 243 tests pass. Resolves #38 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract
PerBulletFeedback,BulletRow, andneedsAttentionout ofResult.tsx(was inline, 167 lines) into a new feature component atsrc/components/features/PerBulletFeedback.tsx. Redesigns the flat ~35-row table into an actionable drill-down model.<details>/<summary>disclosure, collapsed by defaultResult.tsxdrops from ~480 to ~320 LOC (now under the 200-LOC-per-component guideline pressure). No logic changed in scoring or parsing.BulletObservationshape untouched. Auto-rewrite stretch deferred per issue scope.Closes #38
Test plan
npm run typecheckcleannpm run testgreen (194 tests)npm run buildcleannpm run dev/npm run preview