Repository navigation
Fix five update methods that sent no request body (ISSUE-152) - #471
Merged
Merged
Conversation
DataDiscovery.update_annotation, TimeKeeper.update_context_event,
SchemaMaker.update_schema_type / update_schema_attribute and
SubjectArea.update_subject_area passed the body positionally to
_async_update_element_body_request(url, prop=None, body=None), so it
landed in `prop` and the call failed before sending anything
("'NoneType' object has no attribute 'model_dump_json'"). They now pass
body=body.
Micro-tests: tests/micro-tests/test_issue_152_update_body_slot.py (a
dict and a model body through each method; all 10 fail on the old
lines). Full micro-test suite passes in a clean python:3.13-slim
container.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
to dwolfson/egeria-python
that referenced
this pull request
Oct 21, 2026
Ships the ISSUE-152 fix from odpi#471: five update methods (update_annotation, update_context_event, update_schema_type, update_schema_attribute, update_subject_area) now send their body. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
dwolfson
added a commit
that referenced
this pull request
Oct 21, 2026
Ships the ISSUE-152 fix from #471: five update methods (update_annotation, update_context_event, update_schema_type, update_schema_attribute, update_subject_area) now send their body. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE-152 in PYEGERIA_ISSUES.md: five update methods sent no request body.
_async_update_element_body_request(url, prop=None, body=None)takes the body as its third parameter. These callers passed it positionally as the second, so it landed inprop,bodywasNone, and every call failed before sending anything ("'NoneType' object has no attribute 'model_dump_json'"):DataDiscovery.update_annotationTimeKeeper.update_context_eventSchemaMaker.update_schema_typeandupdate_schema_attributeSubjectArea.update_subject_areaEach now passes
body=body. The ISSUE-152 entry is updated to say so.Testing
tests/micro-tests/test_issue_152_update_body_slot.pysends a dict body and anUpdateElementRequestBodythrough each method, and checks that the body reaches the HTTP layer with the right URL. All 10 cases fail on the old lines and pass with the fix.python:3.13-slimcontainer with no Egeria.update_annotationand carry workarounds until a release includes this.🤖 Generated with Claude Code