New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve item abilities and attributes #3176

Merged

howardchung merged 2 commits into odota:master from builder-247:item-tooltip-fix

May 14, 2024

Member

builder-247 commented May 9, 2024 •

edited

Loading

This PR fixes two issues with item tooltips:

Ability name detection was detection based on a regex relying on capitalization, which was inconsistent for a few items e.g. Bloodstone
Added support for uppercase stats displayed at the bottom:

Requires a release from odota/dotaconstants#156


          Improve item abilities and attributes

c9df3e5

Member

howardchung commented May 13, 2024

Published new dotaconstants


          bump dc

eee4dd3

builder-247 marked this pull request as ready for review

May 14, 2024 07:13

howardchung approved these changes

View reviewed changes

howardchung merged commit 09ad0aa into odota:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet