Skip to content

[FIX]hr_payroll_account: Incorrect user error due to line variable #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ezoer-elementure wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[FIX]hr_payroll_account: Incorrect user error due to line variable #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion om_hr_payroll_account/models/hr_payroll_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def action_payslip_done(self):
'journal_id': slip.journal_id.id,
'date': date,
}
if not any(line.salary_rule_id.account_debit and line.salary_rule_id.account_credit for line in slip.details_by_salary_rule_category):
if not any(slip.line_ids.salary_rule_id.account_debit and slip.line_ids.salary_rule_id.account_credit for line in slip.details_by_salary_rule_category):
raise UserError(_('Missing Debit Or Credit Account in Salary Rule'))
for line in slip.details_by_salary_rule_category:
amount = currency.round(slip.credit_note and -line.total or line.total)
Expand Down