[FIX] chart: fix zoom plugin #7621
Closed
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Task Description This commit aims to fix the usage of the zoomWindowPlugin, which draws the zoomed window boundaries on the master chart in a chart. Due to file order, when first calling the registerChartJsExtensions method, the zoomWindowPlugin wasn't added in the chartJsExtensionRegistry yet, and was therefore not added. Unfortunately, each following call to registerChartJsExtension were ignored by the early-return checking if the chartShowValuesPlugin was already registered, which is the case. This fix adds the zoomWindowPlugin in the registry at the same time as the others plugins, fixing this issue by ensuring every plugin is in the registry when we first call the registerChartJsExtension method. Related Task Task: 0
anhe-odoo
force-pushed
the
master-chart-fix_zoom_slicer-anhe
branch
from
0c91700 to
7c04926
Compare
robodoo
pushed a commit
that referenced
this pull request
Dec 10, 2025
Task Description This commit aims to fix the usage of the zoomWindowPlugin, which draws the zoomed window boundaries on the master chart in a chart. Due to file order, when first calling the registerChartJsExtensions method, the zoomWindowPlugin wasn't added in the chartJsExtensionRegistry yet, and was therefore not added. Unfortunately, each following call to registerChartJsExtension were ignored by the early-return checking if the chartShowValuesPlugin was already registered, which is the case. This fix adds the zoomWindowPlugin in the registry at the same time as the others plugins, fixing this issue by ensuring every plugin is in the registry when we first call the registerChartJsExtension method. Related Task closes #7621 Task: 0 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
This commit aims to fix the usage of the
zoomWindowPlugin, which draws the zoomed window boundaries on the master chart in a chart.Due to file order, when first calling the
registerChartJsExtensionsmethod, thezoomWindowPluginwasn't added in thechartJsExtensionRegistryyet, and was therefore not added. Unfortunately, each following call toregisterChartJsExtensionwere ignored by the early-return checking if thechartShowValuesPluginwas already registered, which is the case.
This fix adds the
zoomWindowPluginin the registry at the same time as the others plugins, fixing this issue by ensuring every plugin is in the registry when we first call theregisterChartJsExtensionmethod.Related Task
N./A.