Skip to content

Conversation

@rmbh-odoo
Copy link
Contributor

Description:

Current behavior before PR:

  • Clicking the data validation icon incorrectly triggered the grid onCellClicked handler.
  • After the recent change allowing zone deselection on mouseup,
    This unintended click caused a recomputation of the selection and closed
    the data validation autocomplete popover.

Desired behavior after PR is merged:

  • Clicking the icon no longer triggers the grid’s onCellClicked handler.
  • This prevents the unnecessary selection recomputation and keeps the
    autocomplete popover open during icon interaction.

Task: 5392156

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

…l click

Before this commit:
- Clicking the data validation icon incorrectly triggered the grid
`onCellClicked` handler.
- After the recent change allowing zone deselection on mouseup,
  This unintended click caused a recomputation of the selection and closed
  the data validation autocomplete popover.

After this commit:
- Clicking the icon no longer triggers the grid’s `onCellClicked` handler.
- This prevents the unnecessary selection recomputation and keeps the
  autocomplete popover open during icon interaction.

Task: 5392156
@robodoo
Copy link
Collaborator

robodoo commented Dec 9, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants