[IMP] ecommerce: update product/attribute page #12922
Conversation
|
|
task-3506952
lman-odoo
force-pushed
the
17.0-ecommerce-products-page-lman
branch
from
270d2ef to
5538837
Compare
There was a problem hiding this comment.
Thank you @lman-odoo for your work! I realized while reviewing it that the task's specs weren't clear and accurate regarding the Ecommerce description field (see my comment on lines 162-165). This is on me, I'm sorry!
I added a few other comments/suggestions; let me know if you have any questions! Also, don't forget the 100th character limit (line 170 and lines 235-244 in the products.rst file) 😉
| To do so, click the :icon:`fa-pencil` :guilabel:`(pencil)` icon that appears when clicking the | ||
| :icon:`fa-camera` :guilabel:`(camera)` icon. |
There was a problem hiding this comment.
| To do so, click the :icon:`fa-pencil` :guilabel:`(pencil)` icon that appears when clicking the | |
| :icon:`fa-camera` :guilabel:`(camera)` icon. | |
| To do so, click the :icon:`fa-camera` :guilabel:`(camera)` icon, then click the :icon:`fa-pencil` :guilabel:`(pencil)` icon and select an image from your local drive. |
- We usually try and list the actions to take in chronological order.
- I think we can add the image selection in this sentence and remove it from line 181.
| .. image:: variants/attribute-value-add-image.png | ||
| :align: center | ||
| :alt: Add an image of the pattern to an attribute. |
There was a problem hiding this comment.
I would move this image to line 155 and replace the image file attribute-value-add-a-line.png with this one as this image that you added is basically an updated version of that one.
We also don't center-align images anymore so you can remove :align: center from the images in this (soon-to-be--) note.
| @@ -169,6 +169,23 @@ specifications that are specific to this particular value). | |||
| Or, choose a specific color by clicking the *dropper* icon, and selecting a desired color that's | |||
| currently clickable on the screen. | |||
|
|
|||
| If you sell products with specific patterns, you can also add an image to display the pattern of the product. | |||
There was a problem hiding this comment.
I think line 172 goes over the 100th-character limit.
Also, I know you didn't write/change this, but I would use this opportunity to review the entire note actually (sorry!):
- Turn the note into a sub-section "Colors"; I think this is a bit too much content for a note (it already was IMO)
- Remove the image (and corresponding file) picking-a-color.png on line 162 as I don't think it adds much value.
- Rephrase the first part of the note to avoid this weird phrasing: the option to add an HTML
color code will appear to the far-right of the value line, to make it easier for salespeople and
customers to know exactly what color option they're choosing. I also don't think we need to go to a new paragraph so much.
There was a problem hiding this comment.
I think this file can be deleted as it's not used anywhere?
| From here, you can add an additional, detailed product description especially for marketing purposes | ||
| that will only be visible on your ecommerce product page. To do so, click the text field beneath | ||
| the **sales description** located right under the product name. You can use the `/` command to add images, | ||
| tables and other features. |
There was a problem hiding this comment.
I'm sorry, I think the task's specs weren't clear and accurate; by Ecommerce description, we meant this field on the product form (only available from 18.0 🙈 ).
Let's remove this paragraph and leave this section as it was, and then once this is merged, we can make that change on the 18.0 fw-port branch (it will need to be added in another part of this doc page though).
| The media resources will appear on the ecommerce product page where you can adapt their layout. | ||
|
|
||
| To customize the images available on the product page, go to the :guilabel:`Customize` tab: | ||
| To do so, go to the ecommerce product page, click :guilabel:`Edit` and select an image. In the :guilabel:`Customize` |
There was a problem hiding this comment.
To avoid repetitions and be a bit more accurate, I'd suggest changing lines 241 to 243 as follows:
To customize the images or videos, go to the ecommerce product page, click :guilabel:Edit, and select the relevant media. In the :guilabel:Customize
| You can add additional media items to provide visual resources (i. e. images and videos) and information on | ||
| your product. | ||
|
|
||
| Navigate to the :ref:`product form <ecommerce/products/product-form>`, then go to the :guilabel:`Sales` tab |
There was a problem hiding this comment.
I would simplify this (I don't think it's necessary to explain why you'd want to add images 😉 ):
| You can add additional media items to provide visual resources (i. e. images and videos) and information on | |
| your product. | |
| Navigate to the :ref:`product form <ecommerce/products/product-form>`, then go to the :guilabel:`Sales` tab | |
| To add more media items, such as images and videos, navigate to the :ref:`product form <ecommerce/products/product-form>`, then go to the :guilabel:`Sales` tab |
| your product. | ||
|
|
||
| Navigate to the :ref:`product form <ecommerce/products/product-form>`, then go to the :guilabel:`Sales` tab | ||
| and click :guilabel:`Add a media` under the :guilabel:`Extra Product Media` section. In the resulting |
There was a problem hiding this comment.
| and click :guilabel:`Add a media` under the :guilabel:`Extra Product Media` section. In the resulting | |
| and click :guilabel:`Add a media` under the :guilabel:`Extra Product Media` section. In the |
(not necessary)
| or click the :icon:`fa-pencil` :guilabel:`(pencil)` icon that appears when the cursor hovers | ||
| over the :icon:`fa-camera` :guilabel:`(camera)` icon to upload images from your local drive. |
There was a problem hiding this comment.
| or click the :icon:`fa-pencil` :guilabel:`(pencil)` icon that appears when the cursor hovers | |
| over the :icon:`fa-camera` :guilabel:`(camera)` icon to upload images from your local drive. | |
| or hover your mouse over the :icon:`fa-camera` :guilabel:`(camera)` icon and click the :icon:`fa-pencil` :guilabel:`(pencil)` icon to upload images from your local drive. |
(same as above: to try and list the actions in chronological order to make the steps easier to follow)
task-3506952