[FIX] Harden CI, enforce coverage, and expand tests for stability#138
Open
[FIX] Harden CI, enforce coverage, and expand tests for stability#138
Conversation
brinkflew
force-pushed
the
avs-stability
branch
from
9b7c740 to
f07b2ff
Compare
brinkflew
added
enhancement
brinkflew
force-pushed
the
avs-stability
branch
4 times, most recently
from
43ef013 to
19af527
Compare
sea-odoo
previously approved these changes
Mar 28, 2026
| ) | ||
|
|
||
|
|
||
| ODOO_DB_VERSION = "18.0" |
| stdout, _ = self.dispatch_command("neutralize", self.database_name) | ||
|
|
||
| neutralize.assert_called_once_with() | ||
| self.assertIn("has been neutralized", stdout) |
Contributor
There was a problem hiding this comment.
It only looks about the log ? Not the actual result in the db ?
When topological_sort fails, enumerate simple_cycles and append a human-readable chain to OdevError so users can see which plugins participate in the cycle.
The workflow used a multiline Python version list, which made the matrix non-deterministic; POSTGRES_HOST pointed at a non-existent hostname; and --exitfirst hid secondary failures. CI now pins one Python per job, waits for PostgreSQL, uses localhost for the DB host, pins the apt-cache action, refreshes Odoo cache keys, and runs the full suite with `coverage report`. Coverage had no floor, so regressions could slip through. `fail_under` and `show_missing` align local and CI reporting with CONTRIBUTING. REST had no default timeout and nocache could leave bypass flags set after errors; Postgres `Cursor.transaction` committed after rollback. Defaults and try/finally restore predictable behavior without changing call sites. `fetch` referenced `self.args.name` in an error path (wrong attribute), which crashed instead of surfacing a clean command error. Tests previously picked up the user plugins directory in test mode, so machine-local plugin cycles could break the whole suite. Pointing `plugins_path` at the run temp dir isolates runs. Added tests for `__main__`, connectors, plugin registration and dependency cycles, git/scripts commands, and database info/neutralize/dump.
brinkflew
force-pushed
the
avs-stability
branch
from
19af527 to
1e56350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The workflow used a multiline Python version list, which made the matrix non-deterministic; POSTGRES_HOST pointed at a non-existent hostname; and --exitfirst hid secondary failures. CI now pins one Python per job, waits for PostgreSQL, uses localhost for the DB host, pins the apt-cache action, refreshes Odoo cache keys, and runs the full suite with
coverage report.Coverage had no floor, so regressions could slip through.
fail_underandshow_missingalign local and CI reporting with CONTRIBUTING.REST had no default timeout and nocache could leave bypass flags set after errors; Postgres
Cursor.transactioncommitted after rollback. Defaults and try/finally restore predictable behavior without changing call sites.fetchreferencedself.args.namein an error path (wrong attribute), which crashed instead of surfacing a clean command error.Tests previously picked up the user plugins directory in test mode, so machine-local plugin cycles could break the whole suite. Pointing
plugins_pathat the run temp dir isolates runs.Added tests for
__main__, connectors, plugin registration and dependency cycles, git/scripts commands, and database info/neutralize/dump.Compliance
docsdirectoryrequirements.txtfile, if any