DirectX 12 triangle (SDL2 window) #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-zylinski
force-pushed
the
directx12-sdl-triangle
branch
from
e530c2f to
ea059e2
Compare
|
Build error looks like CI error. The line it reports does not contain that code. |
|
I saw the discord message and look into it. CI uses latest master commit on Odin right? Seems like the latest commit to that file introduced spaces. |
|
Thanks, I had forgotten to sync my Odin fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/check.yml?Side note:
I know the d3d11 example is in
sdlfolder. I'll move that one to the directx folder in a separate PR after this one has been merged. It makes more sense that d3d examples live in the directx folder. The SDL stuff is just for opening the window; the meat of those examples is d3d.