-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] wgpu: Update bindings from v22.1.0.1 to v24.0.0.1 #4888
Draft
Valakor
wants to merge
19
commits into
odin-lang:master
Choose a base branch
from
Valakor:wgpu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided by wgpu-native
…his won't work until a new wgpu-native release is created with the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm marking this Draft because of a few design questions, and because I haven't yet figured out how to update
wgpu.js
properly.Notable differences and things I'd like feedback on:
wgpuSurfacePresent
,wgpuAdapterGetInfo
, andwgpuSurfaceGetCapabilities
.Status
only has the valuesSuccess
andError
at the moment. This fits nicely with the (value, ok) return idiom in Odin if I were to translate the API values to bools instead, but would break if Status ever gains additional values.StringView
type. I've added some helpers (extra constants, creation functions, and a user formatter) that don't exist in the actual WGPU API but I wasn't sure what general policy was on API extras like these.wgpu.js
. Maybe @laytan has thoughts here? Some notable changes:StringView
typeu64
instead ofu32