Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opengl's check_error helper procedure not printing errors in debug builds #4846

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −11
Open

Fix opengl's check_error helper procedure not printing errors in debug builds #4846

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1a99c
Fix opengl's `check_error` helper procedure not printing errors in de…
Memresable Feb 15, 2025
2cad0b0
Fix few typos
Memresable Feb 15, 2025
08fc989
Remove unecessary semicolons
Memresable Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions vendor/OpenGL/helpers.odin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,14 @@ when GL_DEBUG {
last_compile_error_type = type

log_func(id, i32(info_log_length), nil, raw_data(last_compile_error_message), loc)
//fmt.printf_err("Error in %v:\n%s", type, string(last_compile_error_message[0:len(last_compile_error_message)-1]));
fmt.eprintf("Error in %v:\n%s", type, string(last_compile_error_message[0:len(last_compile_error_message)-1]))
} else {

delete(last_link_error_message)
last_link_error_message = make([]byte, info_log_length)
last_compile_error_type = type
last_link_error_type = type

log_func(id, i32(info_log_length), nil, raw_data(last_link_error_message), loc)
//fmt.printf_err("Error in %v:\n%s", type, string(last_link_error_message[0:len(last_link_error_message)-1]));
fmt.eprintf("Error in %v:\n%s", type, string(last_link_error_message[0:len(last_link_error_message)-1]))
}

return false
Expand All @@ -97,21 +96,20 @@ when GL_DEBUG {
if result == 0 {
if log_func == GetShaderInfoLog {
delete(last_compile_error_message)
last_compile_error_message = make([]u8, info_log_length)
last_link_error_type = type
last_compile_error_message = make([]byte, info_log_length)
last_compile_error_type = type

log_func(id, i32(info_log_length), nil, raw_data(last_compile_error_message))
fmt.eprintf("Error in %v:\n%s", type, string(last_compile_error_message[0:len(last_compile_error_message)-1]))
// fmt.eprintf("Error in %v:\n%s", type, string(last_compile_error_message[0:len(last_compile_error_message)-1]))
} else {
delete(last_link_error_message)
last_link_error_message = make([]u8, info_log_length)
last_link_error_message = make([]byte, info_log_length)
last_link_error_type = type

log_func(id, i32(info_log_length), nil, raw_data(last_link_error_message))
fmt.eprintf("Error in %v:\n%s", type, string(last_link_error_message[0:len(last_link_error_message)-1]))

// fmt.eprintf("Error in %v:\n%s", type, string(last_link_error_message[0:len(last_link_error_message)-1]))
}

return false
}

Expand Down