Skip to content

Respect CSS cascade when determining anchor-name #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 24, 2024

Fixes #218, #212

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit 048dfd4
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/66a27c0fe47d580008d46de5
😎 Deploy Preview https://deploy-preview-222--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit 048dfd4
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/66a27c0f2c7a45000869f52a

@mmalerba mmalerba force-pushed the anchor-name-cascade branch from 0550ab2 to 9fc927b Compare July 24, 2024 21:24
@mmalerba mmalerba marked this pull request as ready for review July 24, 2024 21:27
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and goes a long way toward #216 as well. A few typos and minor comments, but nothing concerning functionality. 👏

Co-authored-by: Jonny Gerig Meyer <[email protected]>
@mmalerba mmalerba force-pushed the anchor-name-cascade branch from d22e94e to 048dfd4 Compare July 25, 2024 16:23
@jgerigmeyer jgerigmeyer merged commit bb779c7 into oddbird:main Jul 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] anchor-name doesn't respect CSS cascade
2 participants