Skip to content

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Sep 24, 2025

Run npx http-server .
Open http://localhost:8080/src/dropdown

@dvdherron
Copy link

@jamesnw I have some style cleanup edits I thought would be easier to do locally. Could you grant me access here?

@jamesnw
Copy link
Collaborator Author

jamesnw commented Sep 25, 2025

@dvdherron Whoops, sorry- you should have access now!

@dvdherron dvdherron requested a review from stacyk September 25, 2025 20:14
@dvdherron
Copy link

@stacyk This is ready for style review whenever you're ready

Comment on lines 36 to 39
ul {
position-area: span-block-end inline-end;
position-try: block-end span-inline-end;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdherron Is this the clearest way of selecting 2nd level menus? I'm wondering if the selector should be .menu here as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought I saw the .menu selector on the submenus- but I didn't. Should there be?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I see what's happening now. The inner menus should open on the right. I renamed these to .sub-menu to make that clearer. There should only be a class of .sub-menu on the nested <ul>s. Do you think that's more clear and behaving as you intended?

Changes here @jamesnw c26fa95

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's great! Thanks! I think that's clearer than just basing it on semantics and hierarchy.

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for oddbaseline ready!

Name Link
🔨 Latest commit a6fc2e3
🔍 Latest deploy log https://app.netlify.com/projects/oddbaseline/deploys/68f20ef3c12de10008636d9e
😎 Deploy Preview https://deploy-preview-1--oddbaseline.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants