add include and libraries files path environment variables #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on macos arm64 architectures, homebrew doesn't automatically link the include files and libraries automatically. Before it pointed to the installation path of
/usr/local, but it doesn't anymore.This creates a situation where building some packages fail on these architectures because the compiler can't find the expected include files. Eg ci build in arm64 vs intel.
I'm not sure this is the way maintainers expect to fix this situation, but I think this is a good place to do it. I imagine that trying to fix this inside the homebrew ecosystem would be a big task, and googling a bit, it seems that other programming languages ecosystems with the same issues didn't fix it at the homebrew level too.
This change was triggered by this comment, and by the personal experience of having to fix this on my machine too.
The downside I can see for this approach is that some packages might pass on ocaml CI, but then fail on the user's machines, but I think it's then up to them to look into how to fix it, or ask in discuss.ocaml.org
I don't know how to test these changes and would appreciate some guidance or help.
Please advise if this isn't the way to fix the situation, so that we can try to fix this, as it would be good for quite some packages, i'd say
Thank you