perf(voice): reuse a process-wide HTTP client for Volcano cloud TTS#1497
Draft
alan0x wants to merge 1 commit into
Draft
perf(voice): reuse a process-wide HTTP client for Volcano cloud TTS#1497alan0x wants to merge 1 commit into
alan0x wants to merge 1 commit into
Conversation
Per-sentence reply synthesis built a fresh `reqwest::Client` on every call, so each sentence paid a new TCP+TLS handshake to bytedance. Share one process-wide client via `OnceLock` so reqwest pools connections (keep-alive) across the sentence-streamed TTS path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Per-sentence reply synthesis built a fresh
reqwest::Clienton every call, so each sentence paid a new TCP+TLS handshake to bytedance. Share one process-wide client viaOnceLockso reqwest pools connections (keep-alive) across the sentence-streamed cloud TTS path.Why
Cheap, zero-risk latency win on the cloud TTS path: a voice reply is synthesized sentence-by-sentence, and each sentence was opening a brand-new HTTPS connection. Reusing the client removes the per-sentence handshake (tens–hundreds of ms each).
Scope
Single file (
voice_turn.rs), 22 lines. No behaviour change, no API change — only connection reuse. Unit test asserts the client is a shared instance (volcano_client_is_reused_across_calls).This is the first, independently-mergeable slice of a larger cloud-TTS latency effort; the remaining streaming work is parked on a separate branch pending a baseline first-audio measurement.
🤖 Generated with Claude Code