feat(api): stream serve daemon logs#1226
Open
ymote wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Current-main validation refresh for #904. Scope validated:
Commands run:
Results:
Code/acceptance inspection:
Current-main blocker found:
Remaining gap:
|
dfaeccc to
5edab6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/admin/serve/logsas an admin-auth SSE stream for the main daemon rolling log.tail_n, case-insensitive whole-line regexgrep, RFC3339since, simple poll-based live tail, daily log rotation detection, and line redaction for common credential patterns.Closes #904
Current refresh
origin/main1df02bdValidation
git diff --check origin/main...HEADrustfmt --check crates/octos-cli/src/api/admin.rs crates/octos-cli/src/api/router.rscargo fmt --all -- --checkCARGO_TARGET_DIR=/private/tmp/octos-1226-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli --features api serve_log -- --nocapture(3 passed)CARGO_TARGET_DIR=/private/tmp/octos-1226-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo check -p octos-cli --features api --all-targets(passes with existing unrelated warning noise)CARGO_TARGET_DIR=/private/tmp/octos-1226-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy -p octos-cli --features api --all-targets --no-deps(exits 0 with existing unrelated clippy warning noise)git status --short --branchandgit ls-files --others --exclude-standardin the isolated clone show no untracked/generated files.Notes
-D warningsremains blocked by pre-existing warnings outside this slice, so this refresh records the clean exit of the repository-standard clippy invocation without widening the PR.CI / merge status
5edab6a69f7d0ad31cbac9a7b346d0de369168f2:check,test-octos-cli,test-octos-agent (lib),test-octos-agent (integration),dashboard,swarm-app,check-matrix,typos, and author-email passed. Optional platform/e2e/security expansion jobs were skipped by workflow conditions.MERGEABLEbut branch-protection blocked by required review (BLOCKED/REVIEW_REQUIRED).