You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy -p octos-cli --all-targets --features api --no-deps (exits 0 with existing unrelated warning noise)
git status --short --branch and git ls-files --others --exclude-standard in the isolated clone show no untracked/generated files.
Notes
Full clippy with -D warnings remains blocked by pre-existing warnings outside this slice, so this refresh records the clean exit of the repository-standard clippy invocation without widening the PR.
CI / merge status
GitHub CI is green on head 72b3ff9a7b728617a34058b09545ecc2436b13af: check, test-octos-cli, test-octos-agent (lib), test-octos-agent (integration), dashboard, swarm-app, check-matrix, typos, and author-email passed. Optional platform/e2e/security expansion jobs were skipped by workflow conditions.
Current GitHub state remains MERGEABLE but branch-protection blocked by required review (BLOCKED / REVIEW_REQUIRED).
Validated PR head 3733aed1a8da98ad693d88c9dc3d0690049de6c3 by cleanly merging it onto current origin/main1fb4c88e020242d82cee245b331798ed6dc551e7 in /private/tmp/octos-1222-current-Cl0yOk; local rehearsal merge commit was 62beb8a313907e89f8709f5c956a334ed4d96c57.
Acceptance evidence:
/soul read/write/reset now use a profiled base chat key, so profile/channel/chat isolate the soul while topic sessions for the same chat share it.
SessionActor appends the scoped soul for the spawned session key when building the system prompt.
Tests cover per-chat isolation, per-profile isolation, topic sharing for the same chat, and reset not clearing another chat soul.
cargo clippy -p octos-cli --all-targets --features api --no-deps passed with existing warnings.
Environment: rustc 1.95.0 (59807616e 2026-04-14), cargo 1.95.0 (f2d3ce0bd 2026-03-21), Darwin 25.5.0 arm64. Build/test artifacts were confined to /private/tmp/octos-1222-current-1fb4-*; git ls-files --others --exclude-standard was empty after validation.
Remaining gap: cargo fmt --all -- --check still fails on current-main formatting drift outside this PR diff, observed in crates/octos-cli/src/api/ui_protocol_ledger.rs. GitHub reports this PR as MERGEABLE but branch protection is BLOCKED because review is still required, so I did not merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/souloverrides under a profile/channel/chat-scoped session path instead of the shared profile data root./soulusing the inbound message profiled base session key so Telegram/Discord chats and profiles do not overwrite each other.Closes #626
Current refresh
origin/main1df02bdValidation
git diff --check origin/main...HEADrustfmt --check crates/octos-cli/src/gateway_dispatcher.rs crates/octos-cli/src/session_actor.rs crates/octos-cli/src/soul_service.rscargo fmt --all -- --checkCARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli soul_service::tests -- --nocapture(7 passed)CARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli gateway_dispatcher::tests::should_isolate_soul -- --nocapture(2 passed)CARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli gateway_dispatcher::tests -- --nocapture(34 passed)CARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy -p octos-cli --all-targets --no-depsCARGO_TARGET_DIR=/private/tmp/octos-1222-refresh-target CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy -p octos-cli --all-targets --features api --no-deps(exits 0 with existing unrelated warning noise)git status --short --branchandgit ls-files --others --exclude-standardin the isolated clone show no untracked/generated files.Notes
-D warningsremains blocked by pre-existing warnings outside this slice, so this refresh records the clean exit of the repository-standard clippy invocation without widening the PR.CI / merge status
72b3ff9a7b728617a34058b09545ecc2436b13af:check,test-octos-cli,test-octos-agent (lib),test-octos-agent (integration),dashboard,swarm-app,check-matrix,typos, and author-email passed. Optional platform/e2e/security expansion jobs were skipped by workflow conditions.MERGEABLEbut branch-protection blocked by required review (BLOCKED/REVIEW_REQUIRED).