fix(gateway): make CLI shutdown prompt#1215
Conversation
|
Current-main validation refresh for #381. Scope validated:
Commands run:
Results:
Current-main blocker found:
Issue fit:
Remaining gap:
|
|
Validation evidence for #1215 against current Scope checked:
SHAs:
Environment:
Commands run:
Artifacts:
Remaining gaps / gates:
|
739a9c1 to
f6d2ccd
Compare
|
Refreshed this #381 closure PR onto current Evidence:
The PR still carries |
|
Refreshed CI is green at head Required jobs succeeded: Merge remains blocked only by required review ( |
5744aec to
7b84f33
Compare
7b84f33 to
a9fb8c6
Compare
Summary
quitandexitas gateway CLI exit commands alongside/quit,/exit, and:q, so bare exit words are not dispatched as chat.Notifyso Ctrl-C/runtime shutdown wakes the stdin loop promptly.run_async()return to avoid Tokio stdin teardown holding the terminal.Closes #381
Current-main refresh
origin/mainf6936c452389c5172496ee0c3e13393956086d92.a9fb8c6787605ac13d8cdc368ab90c9264bbdf12./private/tmp/octos-1393-f693.c8Xuzv/octos.rustc 1.95.0 (59807616e 2026-04-14),cargo 1.95.0 (f2d3ce0bd 2026-03-21), Darwin25.5.0arm64./private/tmp;git ls-files --others --exclude-standardwas empty in the isolated checkout.Validation
git diff --check origin/main...HEADpassed.cargo fmt --all -- --checkpassed.rustfmt --checkpassed.typospassed.CARGO_TARGET_DIR=/private/tmp/octos-1215-f693-target-bus CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-bus --lib recognizes_gateway_exit_commands -- --nocapturepassed: 1/1.CARGO_TARGET_DIR=/private/tmp/octos-1215-f693-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli --features api --lib cli_shutdown_timeout_stays_prompt -- --nocapturepassed: 1/1.CARGO_TARGET_DIR=/private/tmp/octos-1215-f693-target-clippy CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy --workspace --all-targets -- -D warningspassed.CARGO_TARGET_DIR=/private/tmp/octos-1215-f693-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo build -p octos-cli --features api --bin octospassed.quit:/usr/bin/expectspawnedoctos gateway --cwd /private/tmp/... --data-dir /private/tmp/... --provider ollama --model llama3.2, waited forGateway ready, sentquit, observedGateway stopped., and reached EOF within a 10s timeout./usr/bin/expectspawned the same non-production gateway path, waited forGateway ready, sent Ctrl-C, observedShutting down gateway..., observedGateway stopped., and reached EOF within a 10s timeout.CI / merge status
a9fb8c6787605ac13d8cdc368ab90c9264bbdf12:check,check-matrix,dashboard,swarm-app,test-octos-agent (lib),test-octos-agent (integration),test-octos-cli,typos, and author-email passed. Optional expansion jobs were skipped.reviewDecision=REVIEW_REQUIRED).