Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(deps): lock file maintenance #72

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

oscard0m
Copy link
Member

Reverts #45

@oscard0m oscard0m added the bug label Aug 16, 2022
@oscard0m oscard0m mentioned this pull request Aug 16, 2022
1 task
@oscard0m oscard0m requested review from a team, gr2m, nickfloyd and timrogers August 16, 2022 08:27
timrogers
timrogers previously approved these changes Aug 16, 2022
@oscard0m
Copy link
Member Author

@wolfy1339 what's your opinion on this? Do we just land the revert(deps) and release a new patch version? Is the semantic commit correct for this use-case?

@wolfy1339
Copy link
Member

The lock file doesn't affect end users. In fact it doesn't even get published.

build or chore are perfectly fine

@oscard0m oscard0m force-pushed the revert-45-renovate/lock-file-maintenance branch from 49bf4d9 to 7f87474 Compare August 16, 2022 13:37
@oscard0m oscard0m force-pushed the revert-45-renovate/lock-file-maintenance branch from 7f87474 to edb9e35 Compare August 16, 2022 13:38
@oscard0m oscard0m enabled auto-merge (squash) August 16, 2022 13:41
@oscard0m oscard0m merged commit 845d45c into main Aug 16, 2022
@oscard0m oscard0m deleted the revert-45-renovate/lock-file-maintenance branch August 16, 2022 14:03
@github-actions
Copy link

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants