Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb through context to gcpkms signer. #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Plumb through context to gcpkms signer. #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/gcpkms/gcpkms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
)

type signingMethodGCP struct {
ctx context.Context
client *kms.KeyManagementClient
}

Expand All @@ -24,7 +25,7 @@ func (s *signingMethodGCP) Verify(string, string, interface{}) error {
}

func (s *signingMethodGCP) Sign(signingString string, ikey interface{}) (string, error) {
ctx := context.Background()
ctx := s.ctx

key, ok := ikey.(string)
if !ok {
Expand All @@ -46,12 +47,14 @@ func (s *signingMethodGCP) Alg() string {
}

type gcpSigner struct {
ctx context.Context
client *kms.KeyManagementClient
key string
}

func New(_ context.Context, client *kms.KeyManagementClient, key string) (ghinstallation.Signer, error) {
func New(ctx context.Context, client *kms.KeyManagementClient, key string) (ghinstallation.Signer, error) {
return &gcpSigner{
ctx: ctx,
client: client,
key: key,
}, nil
Expand All @@ -60,6 +63,7 @@ func New(_ context.Context, client *kms.KeyManagementClient, key string) (ghinst
// Sign signs the JWT claims with the RSA key.
func (s *gcpSigner) Sign(claims jwt.Claims) (string, error) {
method := &signingMethodGCP{
ctx: s.ctx,
client: s.client,
}
return jwt.NewWithClaims(method, claims).SignedString(s.key)
Expand Down