Fix wrong transfer-encoding headers being sent
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ocsigen_response` carries a `Cohttp.Response.t` and a `body` and both of them carry a `transfer-encoding`. The problem is that the `Cohttp.Response.t` is often constructed with a default value for the transfer encoding that takes precedence over the encoding of the body. This changes `Ocsigen_response.make` to remove the header if it is equal to the default value. The correct way to specify the encoding is while constructing the `Body.t` value. Setting the header with `Ocsigen_response.add_header` is also supported. This bug could materialize with pages that never finish loading or with trimmed content. Especially in Eliom, where `Cohttp.Response.make` is often called without the `~encoding` argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ocsigen_responsecarries aCohttp.Response.tand abodyand both of them carry atransfer-encoding.The problem is that the
Cohttp.Response.tis often constructed with a default value for the transfer encoding that takes precedence over the encoding of the body.This changes
Ocsigen_response.maketo remove the header if it is equal to the default value. The correct way to specify the encoding is while constructing theBody.tvalue. Setting the header withOcsigen_response.add_headeris also supported.This bug could materialize with pages that never finish loading or with trimmed content.
Especially in Eliom, where
Cohttp.Response.makeis often called without the~encodingargument.This bug was introduced in #260 while introducing the
Body.ttype.