Skip to content

Modernize runtime #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

Modernize runtime #1937

merged 4 commits into from
Apr 23, 2025

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Apr 16, 2025

No description provided.

@hhugo hhugo force-pushed the modernize-runtime2 branch from 82e2d92 to c20d52a Compare April 16, 2025 11:56
@hhugo hhugo force-pushed the modernize-runtime2 branch from c7d3d48 to 6f7b7f4 Compare April 17, 2025 21:24
@hhugo hhugo marked this pull request as ready for review April 17, 2025 21:34
@hhugo hhugo requested a review from vouillon April 17, 2025 21:34
@hhugo hhugo force-pushed the modernize-runtime2 branch 2 times, most recently from b1d0310 to 8e8ec27 Compare April 19, 2025 05:49
@hhugo
Copy link
Member Author

hhugo commented Apr 22, 2025

following 06e4569, this PR also preserves the payload of nan

@vouillon
Copy link
Member

I'm not sure it is worth it preserving the payload of NaN. Safari and Firefox use NaN boxing, so they have a single NaN values, the others being used internally to encode pointers.

@hhugo hhugo force-pushed the modernize-runtime2 branch from c2e0eae to bfd4988 Compare April 23, 2025 10:08
@hhugo
Copy link
Member Author

hhugo commented Apr 23, 2025

I'm not sure it is worth it preserving the payload of NaN. Safari and Firefox use NaN boxing, so they have a single NaN values, the others being used internally to encode pointers.

Yeah, this was mostly an experiment, I've removed this change.

@hhugo hhugo force-pushed the modernize-runtime2 branch 2 times, most recently from 19b7537 to ce876de Compare April 23, 2025 13:11
@hhugo hhugo force-pushed the modernize-runtime2 branch from ce876de to 4cdf49e Compare April 23, 2025 14:57
@hhugo hhugo merged commit 33fac4f into master Apr 23, 2025
24 of 25 checks passed
@hhugo hhugo deleted the modernize-runtime2 branch April 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants