CI: test wasm on windows #1796
Closed
CI: test wasm on windows #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
commented
Jan 14, 2025
|
@vouillon, I've shortened some names and tests now pass locally. |
|
The CI is now happy. |
|
Replaced by #1799 so we can avoid all renamings |
hhugo
commented
Jan 16, 2025
| @@ -48,7 +53,7 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Set git to use LF | |||
| if: ${{ matrix.os == 'windows-latest' && matrix.ocaml-compiler < 5.2 }} | |||
| if: ${{ matrix.os == 'windows-latest' }} | |||
There was a problem hiding this comment.
I'd like to have the tests pass in presence of CRLF
hhugo
commented
Jan 16, 2025
| - os: windows-latest | ||
| ocaml-compiler: "5.2" | ||
| separate_compilation: true | ||
| jane_street_tests: true |
There was a problem hiding this comment.
@vouillon, jane_street_tests currently doesn't change whether we perform more and less tests. Is that expected ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1797